Skip to content

Update docs #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yadvr merged 5 commits into from
Jun 7, 2021
Merged

Update docs #211

yadvr merged 5 commits into from
Jun 7, 2021

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Apr 27, 2021

No description provided.

@yadvr
Copy link
Member

yadvr commented Apr 27, 2021

@davidjumani conflict on master branch, or is it for 4.15 branch?

@davidjumani davidjumani changed the base branch from master to 4.15 April 27, 2021 10:29
@davidjumani davidjumani marked this pull request as ready for review April 27, 2021 10:29
@davidjumani
Copy link
Contributor Author

davidjumani commented Apr 27, 2021

@rhtyd It's for 4.15, to be merged after #207 is merged

@davidjumani
Copy link
Contributor Author

davidjumani commented Apr 27, 2021

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Apr 27, 2021

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 27, 2021

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 48)

@yadvr
Copy link
Member

yadvr commented May 24, 2021

@davidjumani pl address merge conflicts

@davidjumani
Copy link
Contributor Author

davidjumani commented May 25, 2021

@rhtyd Conflicts resolved

@yadvr yadvr added this to the 4.15 milestone May 25, 2021
@yadvr
Copy link
Member

yadvr commented May 25, 2021

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented May 25, 2021

@rhtyd a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 25, 2021

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 76)

@yadvr yadvr requested a review from andrijapanicsb June 4, 2021 09:35
@yadvr
Copy link
Member

yadvr commented Jun 4, 2021

@andrijapanicsb are you lgtm on this cc @DaanHoogland

@andrijapanicsb
Copy link
Contributor

andrijapanicsb commented Jun 4, 2021

LGTM in regards to the new images.

I have not reviewed tons of other space and indentation changes

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 4, 2021

ok, let's merge, we can always amend as we go (it's only confusing docs anyways) , @rhtyd ?

@yadvr yadvr merged commit 26e4a11 into apache:4.15 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrijapanicsb andrijapanicsb andrijapanicsb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

5 participants

@davidjumani @yadvr @blueorangutan @andrijapanicsb @DaanHoogland